Skip to content

Commit

Permalink
Fix crash on linux mint 22 with nodelist
Browse files Browse the repository at this point in the history
Fixes #1661

The issue was that with gcc13, a missing return statement doesn't get
generated as a return from the function.  Older GCC versions seem to
add in this missing RET.

There may be more of these with gcc-13, will need to look for warnings
if they exist (I didn't see one for this).
  • Loading branch information
wwiv committed Feb 22, 2025
1 parent 8ed6b69 commit b417a84
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions sdk/fido/nodelist.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,7 @@ bool Nodelist::AddEntry(uint16_t zone, uint16_t net, NodelistEntry& e) {
FidoAddress address(zone, net, e.number(), 0, domain_);
e.address(address);
entries_.emplace(address, e);
return true;
}

bool Nodelist::HandleLine(const std::string& line, uint16_t& zone, uint16_t& region, uint16_t& net, uint16_t& hub) {
Expand Down

0 comments on commit b417a84

Please # to comment.