-
Notifications
You must be signed in to change notification settings - Fork 1
pep420 namespace package, add pyproject.toml, bump version #3
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx
I suggest also adding the bootstrap scss files below |
@roland-ruedenauer for first "modernized" release, I wanted to avoid ANY changes except modernizing it. What do you think about xstatic-py/xstatic#15 (comment) ? |
If technically not required, I would have probably not added a dependency an the base xstatic package. As you thankfully updated the existing xstatic-* package releases on PyPI, I currently see no problem with having installed "mixed" xstatic-* packages. Q: Does it make a difference using .rst for the Readme file in a python project? In the xstatic base package you did change the file format. |
b2a4a1b
to
a13e71c
Compare
@roland-ruedenauer I added it so we can update/release all resource packages before xstatic-2.0.0 gets released. Due to the dependency, people will then still all use the old packages. Yeah, with wheels, it seems less problematic. But we can do it nevertheless, just to avoid unforeseen issues. Guess rst renders a bit more pretty. Didn't feel like reformatting all the stuff though. |
I locally tested packaging xstatic-bootrap once again. Please note, that when using find_namespace_packages you get rid off this warning from setuptools occurring for each data subfolder:
|
@roland-ruedenauer Thanks for trying it out and the hint. I updated this PR (bootstrap) and font-awesome with using |
No description provided.