fix PopupProps type error #319
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfilipeferreira96
approved these changes
Sep 17, 2022
|
Already tested and this will fix the typescript errors. |
DerPipo
suggested changes
Nov 30, 2022
| @@ -28,7 +28,7 @@ export interface PopupProps { | |||
| nested?: boolean; | |||
| defaultOpen?: boolean; | |||
| on?: EventType | EventType[]; | |||
| children: React.ReactNode; | |||
| children: React.ReactNode | ((close: () => void, isClose?: boolean) => React.ReactNode); | |||
There was a problem hiding this comment.
Suggested change
| children: React.ReactNode | ((close: () => void, isClose?: boolean) => React.ReactNode); | |
| children: React.ReactNode | ((close: () => void, isOpen: boolean) => React.ReactNode); |
Shouldn't it be called isOpen (instead of isClose)? And as you can see in line 306, the second param is always provided and cannot be undefined, so the ? is unnecessary.
But otherwise the changes look good and should get merged.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi;
there is a type error when you want to pass a function instead a of ReactNode to Popup component.
this issue #315
i just changed the type of children in PopupProps to handle this.