Add semicolon to each statement while dumping the database #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterfox
reviewed
Feb 13, 2024
| @@ -33,7 +33,7 @@ public function dump(Connection $connection, $path): void | |||
| }); | |||
|
|
|||
| if ($statements !== []) { | |||
| $file .= PHP_EOL . $statements[0]['query']; | |||
| $file .= PHP_EOL . $statements[0]['query'] .(ends_with(trim($statements[0]['query']), ';') ? '' : ';'); | |||
There was a problem hiding this comment.
ends_with will never work as the helper isn't installed in all applications with Laravel.
There was a problem hiding this comment.
Suggested change
| $file .= PHP_EOL . $statements[0]['query'] .(ends_with(trim($statements[0]['query']), ';') ? '' : ';'); | |
| $file .= PHP_EOL . Str::finish($statements[0]['query'], ';'); |
And import use Illuminate\Support\Str;
peterfox
requested changes
Feb 13, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes In Code
I added a check to see if the statement is ending with a semicolon. If not, it'll add it so that the .sql file generated is going to work also from the
cockroach sqlcommand