Added some necessary functions #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hazeycode
reviewed
May 4, 2025
| pub const ListBox = struct { | ||
| current_item: *i32, | ||
| items: []const [*:0]const u8, | ||
| height_in_items: i32 = -1, |
There was a problem hiding this comment.
Isn't this a redundant field? Can we just use the length of items?
There was a problem hiding this comment.
height_in_items indicates how many lines are visible.
There was a problem hiding this comment.
Ah makes sense, thanks!
What do you think about using ?u16 here instead?
|
Thanks. I left some comments but this can be merged now. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.