Skip to content

Added convenience when creating ImGui_ImplVulkan_InitInfo #43

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
May 8, 2025
Merged

Added convenience when creating ImGui_ImplVulkan_InitInfo #43

merged 1 commit into from
May 8, 2025

Conversation

Name-hw
Copy link
Contributor

@Name-hw Name-hw commented May 7, 2025 

initInfo.device = @intFromPtr(self.device); -> initInfo.device = self.device;
initInfo.check_vk_result_fn = @ptrCast(&checkVkResult); -> initInfo.check_vk_result_fn = checkVkResult;

hazeycode
hazeycode requested changes May 7, 2025
View reviewed changes
Copy link
Member

@hazeycode hazeycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just one nitpick.

@Name-hw
Added convenience in Vulkan initInfo
7105e02 
initInfo.device = @intFromPtr(self.device); -> initInfo.device = self.device;
initInfo.check_vk_result_fn = @ptrCast(&checkVkResult); -> initInfo.check_vk_result_fn = checkVkResult;
hazeycode
hazeycode approved these changes May 8, 2025
View reviewed changes
Copy link
Member

@hazeycode hazeycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hazeycode hazeycode merged commit 5b2cd20 into zig-gamedev:main May 8, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@hazeycode hazeycode hazeycode approved these changes

Assignees
No one assigned
Labels
breaking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Name-hw @hazeycode