Exiting to main menu while in a choice freezes (softlocks) the game

[drojf]

When we were doing Rei, I fixed a bug where if you exited to the main menu while a choice was on screen, it would freeze the game. The bug was fixed in 5796215.

Edit: Note that if you try to save during a choice, that works fine. It's only if you try to exit to the main menu specifically, not just bringing up the right click menu.

It turns out this bug applies to all? chapters, or at least Himatsubishi, because someone reported the same bug just today, and I could reproduce the bug.

To fix this, we just need to apply the same fix to all chapters, although I may need to change how the code is modified for ch1-4 and ch5-8.

Here is a screenshot of where the reporter got softlocked (they were playing the italian version, but it happens on the English version too). This is from the himatsubishi TIPS number 9, after holding CTRL for about 5 seconds.

From here, when you go into the menu, and click "Exit to menu", the UI fades out, but the text remains, and you can't click on anything anymore.

[drojf]

Oh, I guess there were some other issues with choices for Rei, perhaps it's worth checking them for other chapters

From the Rei "Known Issues" thread: 07th-mod/higurashi-rei#2

Choice menu problems [FIXED?]

I think most of these issues should be fixed in the unreleased v0.0.6, but let me know if you find more/they are still broken

Right now I've only tested the choice menu that appears after you select 'Hirukowashi'.

Note: these issues are likely due to me trying to put in the choice menu without the sharedassets? I need to revise this some time. But I guess I can check if it is the same on previous chapters.

• The hitboxes for the choice menu are completely off - they only activate in the center (as of v0.0.5)
• Exiting the choice via the menu won't let you exit till you select a choice
• Various things can cause the choice menu to break:
  • Spam clicking (continously) from when you click 'Hirukowashi' causes the choice menu to freeze and/or restart the game
  • Skip mode can cause the game to restart
  • Exiting or returning to titlewhile the choice menu is open can sometimes cause the game to freeze
• Also, in general, the choice menu is a little wonky (things like the background bars don't animate with the text)

[drojf]

I made some changes, then tested on Ch.1 and Rei (as the changes are not identical to the ones I made earlier, to fix some other paths which cause problems like loading when a choice is on screen). Seems to work, so should apply branch https://github.com/07th-mod/higurashi-assembly/compare/f-fix-leave-choice in next release to fix this issue.