Add Mod Menu Localization #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…any places in the code
- begin making script to find strings in csharp files
- Make some strings easier to localize
- Fix matching only first string
- Modify functions to suit generated code
- Trial trial adding generated code
- Add localization for the resolution menu
- Fix bad formatting on resolution override button text
- Ensure localization entries have default values always
- Add generated localization file
- Minor updates to code
- Add datetime culture option in localization.json
- Fix localization.json format, ignore commented lines
- Update code to better suit localization script
- Process remaining menu files
- "MOD.Scripts.UI/MODMenuAudioOptions.cs"
- "MOD.Scripts.UI/MODMenuAudioSetup.cs"
- "MOD.Scripts.UI/MODMenuSupport.cs"
- "MOD.Scripts.UI/MODMenu.cs"
- Fix missing long strings
- Fix wrong newline sequence in localization.json
- Fix exception if text is set to null
- Allow setting datetime display format for save file time
- Note: quick save time format was previously differen (missing the day of week), but I've changed it so it is the same as the other formats
- Update voice matching level 5 description
Update extraction script
- Use better replacement ID,
- extract important information into class,
- output code fragments usable by the engine,
- add info comment
- Acommodate switching to jp at runtime by using Properties
13 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, translators were not able to modify text in the mod menu, as all mod menu text were hardcoded strings in the DLL.
This PR loads the strings from a
localization.jsonfile which should be placed atHigurashiEp0X_Data/localization.json(next to thetips.jsonfile).An example
localization.jsonis provided attools/localization.json, which should be updated as a reference for translators.If the
localization.jsonfile is missing, it uses defaults specified in theMOD.Scripts.Core/MODLocalizationData.csfile. This means we don't need to provide alocalization.jsonfile in each of our repositories at this point in time.For more details, see #109
There is one change which isn't directly related to mod menu localization in this file - "Fix exception if toast displayed before gamesystem started" - I think this was because I added a popup if the localization.json file is invalid, but since it was raised so early in the game startup, it would cause an exception (now fixed).