Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add /run/user/$UID to possible IPC Paths #29

Merged
merged 2 commits into from
Jul 24, 2022
Merged

Add /run/user/$UID to possible IPC Paths #29

merged 2 commits into from
Jul 24, 2022

Conversation

SammCheese
Copy link
Contributor

@SammCheese SammCheese commented Jul 24, 2022

After a bit of research, i've found out that Discord added their discord-ipc-? file to that path for me.
This PR should fix rich presences not appearing for some people

Copy link
Owner

@0e4ef622 0e4ef622 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to make a similar change in main.c, although surprising to hear it worked without that.

(Usually /run/user/$UID is what $XDG_RUNTIME_DIR gets set to so maybe the bridge sees that but the script doesn't?)

winediscordipcbridge-steam.sh Outdated Show resolved Hide resolved
@SammCheese
Copy link
Contributor Author

SammCheese commented Jul 24, 2022

Main.c does not need to be edited since the full path (/run/user/$UID/discord-ipc-X) fits the pre-existing "%s/discord-ipc-%d"

EDIT: Nevermind the garbage i was saying here. XDG_RUNTIME_DIR points to /run/user/$UID, which is why it still works.

@SammCheese SammCheese requested a review from 0e4ef622 July 24, 2022 21:31
@0e4ef622
Copy link
Owner

Right and the script also uses $XDG_RUNTIME_DIR so I'm just curious why this is even necessary.

@SammCheese
Copy link
Contributor Author

Right and the script also uses $XDG_RUNTIME_DIR so I'm just curious why this is even necessary.

So am i to be honest, but without that change it just doesnt work.

@0e4ef622 0e4ef622 merged commit 45e66f9 into 0e4ef622:master Jul 24, 2022
@SammCheese SammCheese deleted the patch-1 branch July 24, 2022 22:53
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants