refactor: Merge type unwrapping for types into one step type aliases #104
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously, to unwrap
NON_NULL
-like type references, we would have an outer type handlingT | null
for nullable types, and an inner type handling other refrences.These two steps can be merged by adding an extra argument to the recursive parts of the type reference handler.
This should make some of these types more compact.
Set of changes
unwrapType
with_unwrapTypeRec
intounwrapTypeRec
inselection.ts
unwrapType
with_unwrapTypeRec
intounwrapTypeRec
invariables.ts
unwrapTypeRef
with_unwrapTypeRefRec
intounwrapTypeRefRec
invariables.ts