fix(cli-utils): Add moduleResolution override for NodeNext/Node16
#356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 30e18c6 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
kitten
changed the title
moduleResolution override when NodeNext is setmoduleResolution override for NodeNext/Node16
JoviDeCroock
approved these changes
Jul 30, 2024
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #347 (comment)
Summary
Using
NodeNext/Node16is almost always a mistake. This will disallow extension-less imports, and is almost always not preferred overBundler. In practice,NodeNextis only theBundlerresolution with the added restriction, and if it's used and we get module resolution errors, this was likely a mistake. Overriding it is always safe since it's a super-set ofNodeNext.Set of changes
moduleResolutiontoBundlerif it'sNodeNext/Node16