fix: Improve type output for narrowed interfaces (intersect members of unions instead) #370
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I noticed that the types on interfaces and unions could become quite complex and the type output wasn't nice to read.
Instead of asking TypeScript to narrow using an intersection, we can instead manually narrow any union, since they're expanded in
extends
types.Note: I'm not 100% sure what the type performance impact of this change might be, but the benchmarks indicate that it's negligible.
Follow-up to #368
But issue is also visible before the above PR was merged. It was just rarer
Set of changes