Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: Add missing type alias for initGraphQLTada #377

Merged
merged 2 commits into from
Aug 22, 2024

Conversation

kitten
Copy link
Member

@kitten kitten commented Aug 22, 2024

Resolves #376

Summary

We can make it more obvious how to explicitly declare a type for the initGraphQLTada<>() return type. Currently, replicating it seems unintuitive due to the unexported type helpers that GraphQLTadaAPI requires.

Hence, we can create an overloading type alias called initGraphQLTada<> that evaluates to this type and is then reused by graphql and initGraphQLTada<>()'s return type to explicitly make the type clear.

Set of changes

  • Add initGraphQLTada<> type alias

Copy link

changeset-bot bot commented Aug 22, 2024

🦋 Changeset detected

Latest commit: 127ec4d

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kitten kitten merged commit a5d252f into main Aug 22, 2024
2 checks passed
@kitten kitten deleted the fix/add-type-alias-for-initgraphqltada branch August 22, 2024 15:34
@github-actions github-actions bot mentioned this pull request Aug 22, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue: Explicit type annotation is needed when initialising graphQL tada
2 participants