Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Buttons disappear when a sidebar opened #195

Closed
leic4u opened this issue Nov 21, 2023 · 3 comments
Closed

Buttons disappear when a sidebar opened #195

leic4u opened this issue Nov 21, 2023 · 3 comments

Comments

@leic4u
Copy link
Contributor

leic4u commented Nov 21, 2023

When I open the sidebar of the Monica extension, all elements of the edit page respond correctly except the save and return buttons.

image

@leic4u leic4u added the bug Something isn't working label Nov 21, 2023
@0xJacky
Copy link
Owner

0xJacky commented Nov 23, 2023

It seems like a browser issue

@0xJacky 0xJacky removed the bug Something isn't working label Nov 23, 2023
@leic4u
Copy link
Contributor Author

leic4u commented Nov 23, 2023

It seems like a browser issue

but the other elements response correctly, except the Save and Back buttons only.

@0xJacky
Copy link
Owner

0xJacky commented Nov 26, 2023

Actually, this is not my fault. I use positon: fixed; bottom: 0; right: 0 to make the FooterToolBar fix in the bottom of the screen.

The following documentation is about positon: fixed, excerpted from https://developer.mozilla.org/en-US/docs/Web/CSS/position
image

In my opinion, the browser should change the width of viewport to make sure that elements are not covered by the sidebar extensions.

I also install Monica in Chrome, and it has the same behavior with Edge, it looks like a Chromium issue. Fortunately, I found that using position: sticky can also fix the element in the bottom, so I "fix" this issue in
91817a3.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants