feat(aggsender): add more data to certificate metadata #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…add-more-information-on-metadata-field-of-certificate
…add-more-information-on-metadata-field-of-certificate
Stefan-Ethernal
approved these changes
Nov 28, 2024
joanestebanr
requested changes
Nov 28, 2024
thx, forgot about it when moving out of draft, done. |
joanestebanr
approved these changes
Nov 29, 2024
|
vcastellm
deleted the
CDK-596-aggsender-add-more-information-on-metadata-field-of-certificate
branch
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we're introducing a new struct
CertificateMetadatato represent the data serialized and deserialized to theCertificate.metadatafield.The new data,
FromBlockandCreatedAtis stored in the hash as bigints.NOTE: This PR doesn't take into account backwards compat. We should rethink if this needs to be considered.