feat: limit cert by estimated size #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ToniRamirezM
approved these changes
Dec 3, 2024
vcastellm
reviewed
Dec 3, 2024
vcastellm
reviewed
Dec 3, 2024
goran-ethernal
approved these changes
Dec 3, 2024
|
joanestebanr
added a commit
that referenced
this pull request
Dec 4, 2024
This set a limit on certificate size that can be set on config file (the size of certificate it's an estimation) There are a special situation that is going to send a certificate bigger than maximium: - [ initial_block, end_block ] -> size exceed - [ initial_block, (end_block -1) ] -> no bridges, so we have to send previous one even that exceed the maximum size MaxCertSize: max size in bytes of certificate. Default 8Mb. Currently the maximum on Agglayer is 10Mb ``` [AggSender] MaxCertSize = 8388608 ```
joanestebanr
added a commit
that referenced
this pull request
Dec 4, 2024
* feat: limit cert by estimated size (#217) This set a limit on certificate size that can be set on config file (the size of certificate it's an estimation) There are a special situation that is going to send a certificate bigger than maximium: - [ initial_block, end_block ] -> size exceed - [ initial_block, (end_block -1) ] -> no bridges, so we have to send previous one even that exceed the maximum size MaxCertSize: max size in bytes of certificate. Default 8Mb. Currently the maximum on Agglayer is 10Mb ``` [AggSender] MaxCertSize = 8388608 ``` * feat: return an error in case agglayer returns certificate with height lower than in local storage (#209) --------- Co-authored-by: Stefan Negovanović <93934272+Stefan-Ethernal@users.noreply.github.com>
joanestebanr
added a commit
that referenced
this pull request
Dec 19, 2024
This set a limit on certificate size that can be set on config file (the size of certificate it's an estimation) There are a special situation that is going to send a certificate bigger than maximium: - [ initial_block, end_block ] -> size exceed - [ initial_block, (end_block -1) ] -> no bridges, so we have to send previous one even that exceed the maximum size MaxCertSize: max size in bytes of certificate. Default 8Mb. Currently the maximum on Agglayer is 10Mb ``` [AggSender] MaxCertSize = 8388608 ```
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This set a limit on certificate size that can be set on config file (the size of certificate it's an estimation)
There are a special situation that is going to send a certificate bigger than maximium:
Config
MaxCertSize: max size in bytes of certificate. Default 8Mb. Currently the maximum on Agglayer is 10Mb