Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Rename DepositCount leafIndex (Banana) #274

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Rename DepositCount leafIndex (Banana) #274

merged 1 commit into from
Jul 12, 2024

Conversation

joanestebanr
Copy link
Contributor

@joanestebanr joanestebanr commented Jul 10, 2024 •
edited
Loading

The map l1InfoRootMap contains for each leaf the corresponding root. So the name is more clear leafIndex instead of depositCount

mapping(uint32 leafIndex => bytes32 l1InfoRoot) public l1InfoRootMap;

Also is rename the event InitL1InfoRootMap

@cla-bot cla-bot bot added the cla-signed label Jul 10, 2024
@joanestebanr joanestebanr changed the base branch from main to feature/banana July 10, 2024 09:03
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
19.1% Duplication on New Code

See analysis details on SonarCloud

@invocamanman invocamanman merged commit 5336413 into feature/banana Jul 12, 2024
6 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@invocamanman invocamanman Awaiting requested review from invocamanman

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joanestebanr @invocamanman