Fix DummyProofGenerator serialization
#1634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sai-deng
approved these changes
Oct 16, 2024
muursh
approved these changes
Oct 17, 2024
fengzhizi319
pushed a commit
to fengzhizi319/plonky2
that referenced
this pull request
Nov 1, 2024
* Fix dummy generator serialization * Tweak * Update CODEOWNERS
fengzhizi319
added a commit
to fengzhizi319/plonky2
that referenced
this pull request
Nov 1, 2024
* Fix dummy generator serialization * Tweak * Update CODEOWNERS
fengzhizi319
added a commit
to fengzhizi319/plonky2
that referenced
this pull request
Nov 3, 2024
* Fix dummy generator serialization * Tweak * Update CODEOWNERS
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using the default
common_datato deserializeDummyProofGenerator, which would cause issues when using dummy proofs in a recursive scenario involving different configs.