Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix ArgumentOutOfRangeException #474

Merged
merged 1 commit into from
Aug 17, 2022

Conversation

CreateAndInject
Copy link
Contributor

No description provided.

@wtfsck
Copy link
Contributor

wtfsck commented Aug 15, 2022

Looks like a caller bug not a dnlib bug.

@CreateAndInject
Copy link
Contributor Author

CreateAndInject commented Aug 15, 2022

Looks like a caller bug not a dnlib bug.

Almost all extension methods in the dnlib never occur exceptions
For example :

public static TypeSig GetNext(this TypeSig self) => self?.Next;

The only purpose of this method is : The caller is unnecessary to check when calling

That's why I prevent possible exception to stay the same action to other extension methods

@wtfsck wtfsck merged commit 7a9f0a3 into 0xd4d:master Aug 17, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants