Add additional net6.0 target framework #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gives the compiler additional changes to apply optimizations
ElektroKill
commented
Jul 15, 2023
| if (prevFunc is not null || prevFunc.Address != address) | ||
| if (prevFunc is not null && prevFunc.Address != address) |
There was a problem hiding this comment.
I'm pretty sure this was an unintentional mixup of the || and && operators which would result in right-hand side being executed only if prevFunc was null causing an NRE. If I'm wrong feel free to correct me.
ElektroKill
commented
Jul 15, 2023
Comment on lines
-1498
to
+1503
| [HandleProcessCorruptedStateExceptions, SecurityCritical] // Req'd on .NET Framework 4.0 | ||
| // Required attributes on .NET Framework 4.0 | ||
| // HandleProcessCorruptedStateExceptions is obsolete on .NET Core and newer | ||
| #if !NETCOREAPP | ||
| [HandleProcessCorruptedStateExceptions] | ||
| #endif | ||
| [SecurityCritical] |
There was a problem hiding this comment.
I've gone ahead and used conditional compilation here to exclude the HandleProcessCorruptedStateExceptions attribute as it is marked with Obsolete and the obsolescence message claims this attribute is ignored by the runtime. I have not verified this behavior. An alternative could be to use #pragma directive to disable the obsolescence warning and still include the attribute in the compiled code just in case it does actually make a difference.
wtfsck
approved these changes
Jul 18, 2023
|
Thanks! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #514
This PR adds support
net6.0target fordnlib. The rationale for this change was discussed in the aforementioned issue and updates the NuGet packages used bydnlibto the latest available versions.I've also gone ahead and replaced most of the usages of string concatenation and replaced it with string interpolation. This allows Roslyn to better take advantage of the faster string API's available in .NET 6. Some code changes were also necessary to resolve warnings regarding obsolete members and platform compatibility of the unmanaged Windows PDB support. A few NRE's which were picked up by code analysis were also fixed!