Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix: No more missing MCP2515 events because the MCP2515 keeps the INTline low UNTIL all EVENTS have been handled. #68

Merged
merged 1 commit into from
Sep 12, 2022

Conversation

aentinger
Copy link
Member

@aentinger aentinger commented Sep 12, 2022

This fixes #62 and fixes #53.

… line low UNTIL all EVENTS have been handled.
@aentinger aentinger added type: enhancement PR to improve the project. topic: firmware Code that runs on an embedded system. labels Sep 12, 2022
@aentinger aentinger self-assigned this Sep 12, 2022
@github-actions
Copy link

Memory usage change @ 0d7aa10

Board flash % RAM for global variables %
arduino:mbed_edge:edge_control 🔺 +64 - +64 +0.01 - +0.01 🔺 +8 - +8 0.0 - 0.0
arduino:mbed_nano:nano33ble 🔺 +64 - +64 +0.01 - +0.01 🔺 +8 - +8 0.0 - 0.0
arduino:mbed_nano:nanorp2040connect 🔺 +52 - +52 0.0 - 0.0 🔺 +8 - +8 0.0 - 0.0
arduino:mbed_portenta:envie_m4 🔺 +64 - +64 +0.01 - +0.01 🔺 +8 - +8 0.0 - 0.0
arduino:mbed_portenta:envie_m7 🔺 +64 - +64 +0.01 - +0.01 🔺 +8 - +8 0.0 - 0.0
arduino:samd:mkr1000 🔺 +52 - +52 +0.02 - +0.02 🔺 +8 - +8 +0.02 - +0.02
arduino:samd:mkrfox1200 🔺 +52 - +52 +0.02 - +0.02 🔺 +8 - +8 +0.02 - +0.02
arduino:samd:mkrgsm1400 🔺 +52 - +52 +0.02 - +0.02 🔺 +8 - +8 +0.02 - +0.02
arduino:samd:mkrnb1500 🔺 +52 - +52 +0.02 - +0.02 🔺 +8 - +8 +0.02 - +0.02
arduino:samd:mkrvidor4000 🔺 +52 - +52 +0.02 - +0.02 🔺 +8 - +8 +0.02 - +0.02
arduino:samd:mkrwan1300 🔺 +52 - +52 +0.02 - +0.02 🔺 +8 - +8 +0.02 - +0.02
arduino:samd:mkrwan1310 🔺 +52 - +52 +0.02 - +0.02 🔺 +8 - +8 +0.02 - +0.02
arduino:samd:mkrwifi1010 🔺 +52 - +52 +0.02 - +0.02 🔺 +8 - +8 +0.02 - +0.02
arduino:samd:mkrzero 🔺 +52 - +52 +0.02 - +0.02 🔺 +8 - +8 +0.02 - +0.02
esp32:esp32:esp32 🔺 +376 - +376 +0.03 - +0.03 🔺 +8 - +8 0.0 - 0.0
rp2040:rp2040:rpipico 🔺 +56 - +56 0.0 - 0.0 🔺 +8 - +8 0.0 - 0.0
Click for full report table
Board examples/MCP2515-CAN-Sniffer
flash
% examples/MCP2515-CAN-Sniffer
RAM for global variables
% examples/MCP2515-Loopback
flash
% examples/MCP2515-Loopback
RAM for global variables
%
arduino:mbed_edge:edge_control 64 0.01 8 0.0 64 0.01 8 0.0
arduino:mbed_nano:nano33ble 64 0.01 8 0.0 64 0.01 8 0.0
arduino:mbed_nano:nanorp2040connect 52 0.0 8 0.0 52 0.0 8 0.0
arduino:mbed_portenta:envie_m4 64 0.01 8 0.0 64 0.01 8 0.0
arduino:mbed_portenta:envie_m7 64 0.01 8 0.0 64 0.01 8 0.0
arduino:samd:mkr1000 52 0.02 8 0.02 52 0.02 8 0.02
arduino:samd:mkrfox1200 52 0.02 8 0.02 52 0.02 8 0.02
arduino:samd:mkrgsm1400 52 0.02 8 0.02 52 0.02 8 0.02
arduino:samd:mkrnb1500 52 0.02 8 0.02 52 0.02 8 0.02
arduino:samd:mkrvidor4000 52 0.02 8 0.02 52 0.02 8 0.02
arduino:samd:mkrwan1300 52 0.02 8 0.02 52 0.02 8 0.02
arduino:samd:mkrwan1310 52 0.02 8 0.02 52 0.02 8 0.02
arduino:samd:mkrwifi1010 52 0.02 8 0.02 52 0.02 8 0.02
arduino:samd:mkrzero 52 0.02 8 0.02 52 0.02 8 0.02
esp32:esp32:esp32 376 0.03 8 0.0 376 0.03 8 0.0
rp2040:rp2040:rpipico 56 0.0 8 0.0 56 0.0 8 0.0
Click for full report CSV
Board,examples/MCP2515-CAN-Sniffer<br>flash,%,examples/MCP2515-CAN-Sniffer<br>RAM for global variables,%,examples/MCP2515-Loopback<br>flash,%,examples/MCP2515-Loopback<br>RAM for global variables,%
arduino:mbed_edge:edge_control,64,0.01,8,0.0,64,0.01,8,0.0
arduino:mbed_nano:nano33ble,64,0.01,8,0.0,64,0.01,8,0.0
arduino:mbed_nano:nanorp2040connect,52,0.0,8,0.0,52,0.0,8,0.0
arduino:mbed_portenta:envie_m4,64,0.01,8,0.0,64,0.01,8,0.0
arduino:mbed_portenta:envie_m7,64,0.01,8,0.0,64,0.01,8,0.0
arduino:samd:mkr1000,52,0.02,8,0.02,52,0.02,8,0.02
arduino:samd:mkrfox1200,52,0.02,8,0.02,52,0.02,8,0.02
arduino:samd:mkrgsm1400,52,0.02,8,0.02,52,0.02,8,0.02
arduino:samd:mkrnb1500,52,0.02,8,0.02,52,0.02,8,0.02
arduino:samd:mkrvidor4000,52,0.02,8,0.02,52,0.02,8,0.02
arduino:samd:mkrwan1300,52,0.02,8,0.02,52,0.02,8,0.02
arduino:samd:mkrwan1310,52,0.02,8,0.02,52,0.02,8,0.02
arduino:samd:mkrwifi1010,52,0.02,8,0.02,52,0.02,8,0.02
arduino:samd:mkrzero,52,0.02,8,0.02,52,0.02,8,0.02
esp32:esp32:esp32,376,0.03,8,0.0,376,0.03,8,0.0
rp2040:rp2040:rpipico,56,0.0,8,0.0,56,0.0,8,0.0

@aentinger aentinger marked this pull request as ready for review September 12, 2022 11:10
@aentinger aentinger merged commit 0f7a9e5 into main Sep 12, 2022
@aentinger aentinger deleted the fix-missing-rx-frames branch September 12, 2022 11:10
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
topic: firmware Code that runs on an embedded system. type: enhancement PR to improve the project.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Bug Report] Can't get interrupts to fire on ESP32 Nano 33 BLE, Example locks up
1 participant