This repository has been archived by the owner on May 26, 2024. It is now read-only.
Fixed typo in several places, Messade -> Message #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #47 +/- ##
=======================================
Coverage 91.35% 91.35%
=======================================
Files 10 10
Lines 370 370
=======================================
Hits 338 338
Misses 32 32
Continue to review full report at Codecov.
|
aentinger
approved these changes
May 17, 2022
There was a problem hiding this comment.
Hi @bismurphy ☕ 👋 Great catch! This reminds me of the phrase "Art, as software, is never finished, only abandoned." Now I did "abandon" (not really, but I stopped polishing it) this peace of software but thanks to your effort it gets polished once more 😉 .
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I'm now working on adding support for more NMEA strings (so be on the lookout for more pull requests! 😄 )
While digging through the existing strings (RMC and GGA) I found that there were a few places referencing incoming messages, but they were called "messade". I believe this is a typo; this pull request has gone through and changed all instances to "Message".