Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix zoom button smaller on some application #242

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

christianesperar
Copy link

@christianesperar christianesperar commented Jun 9, 2016

What does this PR do ?

This will make the zoom button bigger on other app I tried to find related element but no one ovverride the style of this class

How should this be tested ?

Some app might contain this issue

What are the relevant issues ?

Nope, none

This Pull Request includes:

Just zoom css styling

What gif best describes how you feel about this work ?

dump

@manifestinteractive
Copy link
Contributor

There was a PR template with some questions that you deleted while submitting this Pull Request. I will need that information present in the PR in order to review it.

Here is the content that is required for all submitted pull requests:

https://raw.githubusercontent.com/manifestinteractive/jqvmap/master/.github/PULL_REQUEST_TEMPLATE.md

Once that is filled out, I will be able to take a look at this again.

@christianesperar
Copy link
Author

Already update it

@kimbaudi
Copy link

For me, the button size issue happens when parent elements have box-sizing: inherit css styling. The way I resolve this issue is to override .jqvmap-zoomin, .jqvmap-zoomout css to set box-sizing: content-box

.jqvmap-zoomin, .jqvmap-zoomout {
  box-sizing: content-box;
}

@christianesperar
Copy link
Author

Kindly update the status

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants