Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Adding maps translated to polish and poland map. #281

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

fedek6
Copy link

@fedek6 fedek6 commented Feb 27, 2017

What does this PR do ?

I think you should alter names of the maps that anyone could translate them into many languages. Check what I did with the world map.

How should this be tested ?

Simply load one of my maps.

What are the relevant issues ?

This Pull Request includes:

  • Bug Fix with passing npm test
  • New Feature with passing npm test
  • Code Improvement with passing npm test
  • Updated Documentation
  • [ x] New Map File & Example HTML

What gif best describes how you feel about this work ?

👍

Copy link
Contributor

@manifestinteractive manifestinteractive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am OK merging this if we can get rid of the .project file.

BTW, sorry for the super late response to this, been really slammed on my full-time job, there are a few other maintainers on the project, but looks like they are super busy too T_T

@fedek6
Copy link
Author

fedek6 commented May 30, 2017

Hi,
I've added .project file to .gitignore so now it should be ok.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants