Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add "Testing" section to the "CONTRIBUTING.md" file #294

Merged
merged 2 commits into from
May 13, 2024
Merged

Add "Testing" section to the "CONTRIBUTING.md" file #294

merged 2 commits into from
May 13, 2024

Conversation

kmgalanakis
Copy link
Contributor

Description of the Change

Add a Testing section in the CONTRIBUTING.md file.

Changelog Entry

Added - "Testing" section in the "CONTRIBUTING.md" file.

Credits

Props @kmgalanakis

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@kmgalanakis kmgalanakis requested a review from a team as a code owner April 26, 2024 06:32
@kmgalanakis kmgalanakis requested review from iamdharmesh and removed request for a team April 26, 2024 06:32
@github-actions github-actions bot added this to the 1.8.1 milestone Apr 26, 2024
@github-actions github-actions bot added the needs:code-review This requires code review. label Apr 26, 2024
iamdharmesh
iamdharmesh previously approved these changes Apr 26, 2024
View reviewed changes
Copy link
Member

@iamdharmesh iamdharmesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @kmgalanakis. LGTM

@jeffpaul jeffpaul merged commit 6cf31eb into develop May 13, 2024
9 checks passed
@jeffpaul jeffpaul deleted the feature/add-testing-section-to-contributing-file branch May 13, 2024 17:56
@dkotter dkotter modified the milestones: 1.8.1, 1.9.0 Nov 15, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jeffpaul jeffpaul jeffpaul approved these changes

@iamdharmesh iamdharmesh iamdharmesh left review comments

Assignees

@kmgalanakis kmgalanakis

Labels
needs:code-review This requires code review.
Projects
Open Source Practice
Archived in project
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.
4 participants
@kmgalanakis @jeffpaul @iamdharmesh @dkotter