Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Support for copier.yaml files that include other files #84

Merged
merged 3 commits into from
Jun 26, 2024
Merged

Support for copier.yaml files that include other files #84

merged 3 commits into from
Jun 26, 2024

Conversation

davidbrownell
Copy link
Contributor

@davidbrownell davidbrownell commented Jun 24, 2024

copier configuration files can include other files (more info here).

This change adds support for those files by using yaml.safe_load_all to load the yaml content rather than yaml.safe_load. It also includes functionality to support !include.

Copy link
Owner

@12rambau 12rambau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like this PR. Can you create a test to illustrate this feature ?

@davidbrownell
Copy link
Contributor Author

I added tests, but I'm not sure I matched the existing conventions well. Let me know if you have specific changes that you would like to see made.

Copy link
Owner

@12rambau 12rambau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few cosmetic changes and it will be perfect

Changes made based on code review feedback.
Copy link
Owner

@12rambau 12rambau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect, thanks for your valuable contribution. I'll draft a release as it's a wanted feature!

@12rambau 12rambau merged commit 22f2a41 into 12rambau:main Jun 26, 2024
11 checks passed
@12rambau 12rambau linked an issue Jun 26, 2024 that may be closed by this pull request
@davidbrownell davidbrownell deleted the IncludeFiles branch June 26, 2024 12:19
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

!include config does not work
2 participants