Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[FEATURE] 容器仓库配置地址，增加有效性校验 #4542

Closed
huangye123 opened this issue Apr 17, 2024 · 2 comments
Closed

[FEATURE] 容器仓库配置地址，增加有效性校验 #4542

huangye123 opened this issue Apr 17, 2024 · 2 comments
Assignees
@john1298308460 @wanghe-fit2cloud
Labels
Status: Completed Type: Optimization
Milestone
v1.10.12-beta.1

Comments

@huangye123
Copy link

huangye123 commented Apr 17, 2024 •
edited
Loading

1Panel 版本

v1.10.2-lts

请描述您的需求或者改进建议

image

问题1：
配置仓库地址时，带了https,造成后续操作失败，配置时没有校验提醒

问题2：
地址带上https，点击同步按钮，没有异常报错

请描述你建议的实现方案

经过几天排查才发现，建议在前端增加地址不需要http或https的校验，减少不必要的错误。

附加信息

No response
@ssongliu
Copy link
Member

感谢反馈，后续版本优化

@wanghe-fit2cloud wanghe-fit2cloud added this to the v1.10.11-lts milestone Jun 13, 2024
@john1298308460 john1298308460 mentioned this issue Jul 3, 2024
Merged
f2c-ci-robot bot pushed a commit that referenced this issue Jul 3, 2024
@john1298308460
feat: 容器仓库配置地址，增加有效性校 (#5664)
8301382 
Refs #4542
@wanghe-fit2cloud
Copy link
Member

v1.10.12-beta 版本已发布。

KaySar12 pushed a commit to KaySar12/1Panel that referenced this issue Oct 17, 2024
@john1298308460
feat: 容器仓库配置地址，增加有效性校 (1Panel-dev#5664)
59d8554 
Refs 1Panel-dev#4542
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@john1298308460 john1298308460

@wanghe-fit2cloud wanghe-fit2cloud

Labels
Status: Completed Type: Optimization
Projects
None yet
Milestone
v1.10.12-beta.1
Development

No branches or pull requests
5 participants
@huangye123 @john1298308460 @wanghe-fit2cloud @ssongliu @zyyfit