feat: 修改应用安装超时时间 #6983
feat: 修改应用安装超时时间 #6983
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| } | ||
| return err | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
这个代码有一些问题和优化的空间：
- 函数名应该是
pullImages而不是pull-images; - 应该检查 pullImages 的值是否为 false (即默认情况);
- 在写注释时应该更简练直接;
- 由于容器运行时间可能很长，可以在输出中使用字符串格式化或切片打印来展示进度信息。
以上这些改变可以帮助提高代码质量并减少潜在错误。
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wanghe-fit2cloud The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Refs #6985