feat: Fix Issue with DNS Account Deletion After Certificate Update Ap… #7303
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| } | ||
| return geoLocation.Country.Zh + geoLocation.Province.Zh, nil | ||
| return geoLocation.Country.Zh + " " + geoLocation.Province.Zh, nil | ||
| } |
There was a problem hiding this comment.
No significant differences or irregularities found. The code is functioning as expected. No further optimization suggested at this time. Keep it simple and efficient!
| @@ -512,6 +512,8 @@ func (w WebsiteSSLService) Update(update request.WebsiteSSLUpdate) error { | |||
| return err | |||
| } | |||
| updateParams["dns_account_id"] = dnsAccount.ID | |||
| } else { | |||
| updateParams["dns_account_id"] = 0 | |||
| } | |||
| return websiteSSLRepo.SaveByMap(websiteSSL, updateParams) | |||
| } | |||
There was a problem hiding this comment.
The differences and suggestions from this code snippet are:
Differences:
- In the initial line of the function, a different variable
updateis used, whereas it should be named according to our coding standard.
Suggestions:
As per Go's naming conventions, if we were implementing in Java or other statically typed languages like C#, the variable can indeed be renamed accordingly.
func Update(w WebsiteSSLService, params RequestWeblinkSSLUpdate) (*RequestWebsiteSSL, error) {Optimization Suggestions:
- It might slightly improve readability by having consistent formatting when using 'request'.
Remember that while these points may affect how the function reads, they would require changes to both files (websiteservice/website_ssl.go and main/main_test.go). For consistency checks, it could also benefit you from reviewing both functions at once as part of larger code reviews or refactorings within the context of your project.
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wanghe-fit2cloud The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Refs #7300