fix: Fix the issue of pagination errors in the backup list #7673
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| @@ -156,7 +156,6 @@ const currentRow = ref(); | |||
| const data = ref(); | |||
| const title = ref(); | |||
| const paginationConfig = reactive({ | |||
| cacheSizeKey: 'upload-page-size', | |||
| currentPage: 1, | |||
| pageSize: 10, | |||
| total: 0, | |||
There was a problem hiding this comment.
The changes to the code seem mostly correct, but there is a change regarding imports and types. The UploadProps, UploadRawFile types have been added to the import. These likely provide additional functionality such as handling file properties directly within the Vue component.
No other significant irregularities, potential issues, or optimizations were noted in this particular code snippet based on my analysis of its content.
| @@ -883,7 +883,7 @@ const message = { | |||
| perDayHelper: '每日 {0}:{1} 執行', | |||
| perHourHelper: '每小時 {0}分 執行', | |||
| perNDayHelper: '每 {0} 日 {1}:{2} 執行', | |||
| perNHourHelper: '每 {0}小時 {1} 執行', | |||
| perNHourHelper: '每 {0}小時 {1}分 執行', | |||
| perNMinuteHelper: '每 {0}分 執行', | |||
| perNSecondHelper: '每 {0}秒 執行', | |||
| perMonth: '每月', | |||
There was a problem hiding this comment.
The code difference you provided involves updating a message template for scheduling options. Specifically, the "每 {0} 小時 {1}" (per hour) message has been changed to "每 {0} 小時 {1} 分" (every X hours Y minutes), which is more accurate and natural.
Suggestion: Remove the extra space after "{1}" in the original line, resulting in perNHourHelper: '每 {0}小時{1} 執行'.
| @@ -883,7 +883,7 @@ const message = { | |||
| perDayHelper: '每日 {0}:{1} 执行', | |||
| perHourHelper: '每小时 {0}分 执行', | |||
| perNDayHelper: '每 {0} 日 {1}:{2} 执行', | |||
| perNHourHelper: '每 {0}小时 {1} 执行', | |||
| perNHourHelper: '每 {0}小时 {1}分 执行', | |||
| perNMinuteHelper: '每 {0}分 执行', | |||
| perNSecondHelper: '每 {0}秒 执行', | |||
| perMonth: '每月', | |||
There was a problem hiding this comment.
There seems to be an incorrect format for the "perNHourHelper" string. It appears that the current pattern includes minutes (e.g., "每 5小时 30分 执行"), but it might not match expected behavior if hours and minutes were intended separately.
To correct this, you could simplify the string patterns where necessary:
- perNHourHelper: '每 {0}小时 {1} 分执行',
+ perNHourHelper: '每 {0} 小时{1}分钟执行', // Simplify to just hours and minutesThis change ensures consistency between different time units by providing a more straightforward representation of the schedule format.
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wanghe-fit2cloud The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.