Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: audio support m4a #2277

Merged
merged 1 commit into from
Feb 14, 2025
Merged

feat: audio support m4a #2277

merged 1 commit into from
Feb 14, 2025

Conversation

shaohuzhang1
Copy link
Contributor

feat: audio support m4a --story=1017864 --user=王孝刚 【应用】上传音频文件类型中支持m4a类型 #2276 https://www.tapd.cn/57709429/s/1654257

--story=1017864 --user=王孝刚 【应用】上传音频文件类型中支持m4a类型 #2276 https://www.tapd.cn/57709429/s/1654257
Copy link

f2c-ci-robot bot commented Feb 14, 2025

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@@ -260,7 +260,7 @@ const localLoading = computed({
const imageExtensions = ['jpg', 'jpeg', 'png', 'gif', 'bmp']
const documentExtensions = ['pdf', 'docx', 'txt', 'xls', 'xlsx', 'md', 'html', 'csv']
const videoExtensions = ['mp4', 'avi', 'mov', 'mkv', 'flv']
const audioExtensions = ['mp3', 'wav', 'ogg', 'aac']
const audioExtensions = ['mp3', 'wav', 'ogg', 'aac', 'm4a']

const getAcceptList = () => {
const { image, document, audio, video } = props.applicationDetails.file_upload_setting
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no significant issues with the current code, but here is a minor suggestion:

  1. Remove Trailing Commas: The trailing comma after props.applicationDetails.file_upload_setting could be removed to make the syntax more concise.

Revised Code:

@@ -260,7 +260,7 @@
 const localLoading = computed({
 const imageExtensions=['jpg','jpeg','png','gif','bmp']
 const documentExtensions=['pdf','docx','txt','xls','xlsx','md','html','csv']
 const videoExtensions =['mp4','avi','mov','mkv','flv']
-const audioExtensions=['mp3','wav','ogg','aac']
+const audioExtensions=['mp3','wav','ogg','aac','m4a']

 const getAcceptList = () => {
   const {image , document, audio, video} = props.applicationDetails.file_upload_setting

This change makes the syntax cleaner and less error-prone.

Copy link

f2c-ci-robot bot commented Feb 14, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wxg0103 wxg0103 merged commit dd5db3e into main Feb 14, 2025
4 of 5 checks passed
@wxg0103 wxg0103 deleted the pr@main@feat_1017864 branch February 14, 2025 02:39
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants