Add configuration option for new credential ID length #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Progdrasil
reviewed
Oct 23, 2024
complexspaces
force-pushed
the
configurable-credid-length
branch
from
8483dc2 to
df0daa6
Compare
|
LGTM, All that's missing is a changelog entry |
complexspaces
force-pushed
the
configurable-credid-length
branch
from
df0daa6 to
2dda67b
Compare
|
Changelog added 👍 |
Progdrasil
approved these changes
Oct 24, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for authenticators built on-top of
passkey-rsto control what length user handle/credentialId they make for later storage in the passkey provider. Providers may want to randomize or otherwise change this value to prevent authenticator fingerprinting based on well-known lengths.