-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Introduce beta example for deploying on DigitalOcean App Platform using 1Password CLI and deprecate current App Platform example #222
Conversation
Signed-off-by: Adam Pike <adam.pike@1password.com>
Signed-off-by: Adam Pike <adam.pike@1password.com>
43c7c22
to
6edd72c
Compare
Signed-off-by: Adam Pike <adam.pike@1password.com>
In the most recent commit, the GitHub links throughout |
Signed-off-by: Adam Pike <adam.pike@1password.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The shell plugins side of things looks good to me!
Thanks for the review, @accraw! 😊 |
Link to developer docs rather than release notes. Signed-off-by: Adam Pike <adam.pike@1password.com>
Signed-off-by: Adam Pike <adam.pike@1password.com>
Add note regarding TLS certificate management. Signed-off-by: Adam Pike <adam.pike@1password.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this personally and ran through it with a customer. After resolving the base64 issue in d7fb420 I think we're in a good place.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our customers are going to love this!
Well written, concise, informative, and frankly I learned a thing or two while reading.
Thank you for putting these changes together folks!
Signed-off-by: Adam Pike <adam.pike@1password.com>
This PR introduces a beta deployment example that uses the DigitalOcean shell plugin with 1Password CLI to deploy 1Password SCIM bridge on DigitalOcean App Platform.
It also deprecates the current App Platform deployment example in favour of this one to reduce cost and complexity and increase speed of deployment.
Reasons to use this deployment example are detailed in the README, but to summarize:
The deployment example also serves as a practical example of several
op
commands and deploys in seconds.