Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Introduce beta example for deploying on DigitalOcean App Platform using 1Password CLI and deprecate current App Platform example #222

Merged
merged 10 commits into from
Jan 11, 2023

Conversation

ag-adampike
Copy link
Member

@ag-adampike ag-adampike commented Dec 21, 2022

This PR introduces a beta deployment example that uses the DigitalOcean shell plugin with 1Password CLI to deploy 1Password SCIM bridge on DigitalOcean App Platform.

It also deprecates the current App Platform deployment example in favour of this one to reduce cost and complexity and increase speed of deployment.

Reasons to use this deployment example are detailed in the README, but to summarize:

  • For standard deployments, App Platform will host SCIM bridge for a predictable cost of $10 USD/month (at the time of last review).
  • There is no need to set up a DNS record. DigitalOcean automatically provides a URL for SCIM bridge.
  • 1Password SCIM bridge deploys directly to DigitalOcean from a local terminal. There is no requirement to clone this repository for this deployment.

The deployment example also serves as a practical example of several op commands and deploys in seconds.

@ag-adampike ag-adampike self-assigned this Dec 21, 2022
@ag-adampike ag-adampike added enhancement New feature or request documentation For documentation-related issues labels Dec 21, 2022
@ag-adampike ag-adampike force-pushed the pike/do-app-platform-op-cli branch from 43c7c22 to 6edd72c Compare December 21, 2022 23:47
Signed-off-by: Adam Pike <adam.pike@1password.com>
@ag-adampike
Copy link
Member Author

In the most recent commit, the GitHub links throughout README.md won't work until this is merged to master, but they can be replaced with the path to this branch for review (i.e. use https://raw.githubusercontent.com/1Password/scim-examples/pike/do-app-platform-op-cli/beta/do-app-platform-op-cli/op-scim-bridge.yaml).

@ag-adampike ag-adampike marked this pull request as ready for review January 6, 2023 02:58
@ag-adampike ag-adampike removed the documentation For documentation-related issues label Jan 6, 2023
Signed-off-by: Adam Pike <adam.pike@1password.com>
accraw
accraw previously approved these changes Jan 9, 2023
Copy link
Contributor

@accraw accraw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The shell plugins side of things looks good to me!

@ag-adampike
Copy link
Member Author

The shell plugins side of things looks good to me!

Thanks for the review, @accraw! 😊

Link to developer docs rather than release notes.

Signed-off-by: Adam Pike <adam.pike@1password.com>
Signed-off-by: Adam Pike <adam.pike@1password.com>
Add note regarding TLS certificate management.

Signed-off-by: Adam Pike <adam.pike@1password.com>
scottisloud
scottisloud previously approved these changes Jan 11, 2023
Copy link
Collaborator

@scottisloud scottisloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this personally and ran through it with a customer. After resolving the base64 issue in d7fb420 I think we're in a good place.

grellyd
grellyd previously approved these changes Jan 11, 2023
Copy link
Member

@grellyd grellyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our customers are going to love this!

Well written, concise, informative, and frankly I learned a thing or two while reading.

Thank you for putting these changes together folks!

beta/do-app-platform-op-cli/README.md Outdated Show resolved Hide resolved
Signed-off-by: Adam Pike <adam.pike@1password.com>
@ag-adampike ag-adampike merged commit a499dc9 into master Jan 11, 2023
@ag-adampike ag-adampike deleted the pike/do-app-platform-op-cli branch January 11, 2023 21:51
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants