Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Validation logic/structure improvements. Orderbook request param naming refactor. Better Limit Order Receiver defaults. #20

Merged

Conversation

Tanz0rz
Copy link
Collaborator

@Tanz0rz Tanz0rz commented Feb 8, 2024

This PR is mostly focused on continuing to refactor and optimize how validation logic is organized in the project.

A couple smaller changes were included:

  • Orderbook param names have been updated to better match the Orderbook internal structures
  • The Receiver field has an unconventional default value which is now handled by the SDK

…aming. Added better defaults for limit order params.
@Tanz0rz Tanz0rz changed the title Validation logic/structure improvements. Orderbook request param naming refactor. Better Limit Order Receiver defaults Validation logic/structure improvements. Orderbook request param naming refactor. Better Limit Order Receiver defaults. Feb 8, 2024
@Tanz0rz Tanz0rz merged commit 991450f into main Feb 9, 2024
svanas pushed a commit to svanas/1inch-sdk that referenced this pull request Feb 9, 2024
…aming. Added better defaults for limit order params. (1inch#20)
@Tanz0rz Tanz0rz deleted the feature/validation-improvement-struct-renaming-better-defaults branch March 12, 2024 20:35
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant