Fusion SDK Added #70
Merged
Fusion SDK Added #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EnoRage
reviewed
Jun 26, 2024
EnoRage
previously approved these changes
Jun 26, 2024
There was a problem hiding this comment.
TLDR: looks ok, we can make a new PR soon for refactoring / improvements
Except private key usage:
- we do have a wallet abstraction that is used for all operations with private key management
- developer can implement it's own wallet interface if there is a low trust in the default implementation
- will be great to ask wallet interface to sign something, but do no extract the PK from it
EnoRage
approved these changes
Jun 28, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.