-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Added league/flysystem to also be a possible filesystem #213
Conversation
Could someone test it with s3? I will also write some documentation on how to use it, if accepted |
Tested with
|
Hi @lsv ! Thanks for your PR, looks really good to me. And thanks for testing! My bad, that I can't test it with s3... |
The failed tests are PHP 5.3 as flysystem requires PHP 5.4 |
Yes, I saw it. I would say we can skip 5.3 due to the fact that 5.3 is EOL since 14th of august 2014. |
And the reason for using flysystem imo gaufrette is somekind of dead, and lot of other bundles are using flysystem instead. |
Can you drop the 5.3 support in |
Is there an estimate when this fork will be merged? I'm looking forward in using flysystem with this bundle |
Added league/flysystem to also be a possible filesystem
@bytehead Thanks, that was pretty quick :-) |
It was on my list for at least 8 days ;-) |
Wow, this is very good news! It might need some documentation though. Is it as straightforward as replacing gaufrette with flysystem? Does it support chunked uploading? |
When I have a few moments i will write a proper documentation. But for short, change gaufrette to flysystem in storage type.
|
@bytehead well it actually took some time for me to find out that 1up-lab also have flysystem bundle, so I was a bit confused why you have chosen gaufrette :) Anyways, it was actually pretty easy to create this, when I figured out that FileInterface missing a few methods, like move() and so on - I will properly make a PR for this. And also a PR for documentation will come in a near future |
@lsv I can totally understand your confusion 😄 Sounds great - your PRs are always welcome! |
I get a OutOfMemoryException on oneup/uploader-bundle/Oneup/UploaderBundle/Uploader/Storage/FlysystemStorage.php line 47 when uploading a larger file (~400MB). The chunked upload works, but the last step seems to cause the exception. Any ideas? UPDATE: |
Integrated Flysystem so not only gaufrette is a option