Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add native return type declaration to Configuration::getConfigTreeBuilder #416

Merged
merged 1 commit into from
Jul 20, 2022

Conversation

biozshock
Copy link
Contributor

Tests report a deprecation warning when using symfony 5.4.

Method "Symfony\Component\Config\Definition\ConfigurationInterface::getConfigTreeBuilder()" might add "TreeBuilder" as a native return type declaration in the future. Do the same in implementation "Oneup\UploaderBundle\DependencyInjection\Configuration" now to avoid errors or add an explicit @return annotation to suppress this message.

@bytehead
Copy link
Member

@biozshock can you rebase on the actual master or check the box to Allow edits from maintainers?

@bytehead bytehead added the bug label Jan 12, 2022
@bytehead bytehead added this to the 4.x milestone Jan 12, 2022
Copy link
Member

@bytehead bytehead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 The pipeline should be green after rebasing.

@biozshock
Copy link
Contributor Author

@bytehead Checkbox was ticked from the start. Rebased.

@deluxetom
Copy link

+1 to get this merged :)

@bytehead
Copy link
Member

bytehead commented Feb 7, 2022

The tests are still failing tough.

@bytehead
Copy link
Member

bytehead commented Feb 7, 2022

Ah, possibly unrelated.

@bytehead bytehead merged commit 7a778af into 1up-lab:master Jul 20, 2022
@bytehead
Copy link
Member

Thank you @biozshock!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants