Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[feat/#59] 게임 결과 페이지 api 연동 ver 2 #60

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from
Open

[feat/#59] 게임 결과 페이지 api 연동 ver 2 #60

wants to merge 11 commits into from
+158 −13

Conversation

jihye9549
Copy link
Member

추가한 기능 설명

  • msw 사용 게임결과 페이지 api 연동
  • 리액트쿼리
  • 상장 성명 1등 닉네임으로 변경
  • 등급별 닉네임 색깔 변경

check list

  • [✅] issue number를 브랜치 앞에 추가 하였는가?
  • [✅] 모든 단위 테스트를 돌려보고 기존에 작동하던 테스트에 영향이 없는 것을 확인했는가?

@jihye9549 jihye9549 added the FEAT 새로운 기능 추가 label Jul 24, 2023
@jihye9549 jihye9549 self-assigned this Jul 24, 2023
Leeseunghwan7305
Leeseunghwan7305 requested changes Jul 24, 2023
View reviewed changes
Copy link
Member

@Leeseunghwan7305 Leeseunghwan7305 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

전체적으로 잘 짜주셨네요 ! 고생하셨씁니다 !
마지막으로 쓰지않는 코드들은 지워주세요! (회색으로 보이는 코드)

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Leeseunghwan7305 Leeseunghwan7305 Leeseunghwan7305 requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@jihye9549 jihye9549

Labels
FEAT 새로운 기능 추가
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jihye9549 @Leeseunghwan7305