Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

php 8.4 deprecation message #113

Merged
merged 2 commits into from
Feb 4, 2025
Merged

php 8.4 deprecation message #113

merged 2 commits into from
Feb 4, 2025

Conversation

andreypopov
Copy link

Fixes:

PHP Deprecated: saml_url(): Implicitly marking parameter $secure as nullable is deprecated, the explicit nullable type must be used instead in /vendor/24slides/laravel-saml2/src/helpers.php on line 15

Deprecated: saml_url(): Implicitly marking parameter $secure as nullable is deprecated, the explicit nullable type must be used instead in /vendor/24slides/laravel-saml2/src/helpers.php on line 15

More info: https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated

@andreypopov
Copy link
Author

Hi, please, create 2.4.1 release! many thanks!

@KarimGeiger
Copy link

I noticed another error of similar nature:

Deprecated: saml_route(): Implicitly marking parameter $uuid as nullable is deprecated, the explicit nullable type must be used instead in vendor/24slides/laravel-saml2/src/helpers.php on line 40

@kondratovbr
Copy link

Also in RendersTenants.php

@vopolonc
Copy link
Collaborator

vopolonc commented Feb 4, 2025

@andreypopov Thank you for bringing it up (also adjusted a few other places, thank you @kondratovbr for highlighting)

@vopolonc vopolonc merged commit c783b51 into 24Slides:master Feb 4, 2025
1 check passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants