Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[fix] [broker] Fix acknowledgeCumulative block when ackReceipt is enabled #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

315157973
Copy link
Owner

@315157973 315157973 commented Jan 12, 2025

Motivation

Repeated calls to acknowledgeCumulativeAsync will block, when AckReceipt is enabled.

Modifications

Request only sent when MessageID increases.
Therefore, CompletableFuture returned by PersistentAcknowledgmentsGroupingTracker will not be completed.

Verifying this change

  • Make sure that the change passes the CI checks.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant