Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Migrate Docker image from tum-gis/3dcitydb-web-map-docker #88

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

BWibo
Copy link
Member

@BWibo BWibo commented Nov 13, 2024

@thomashkolbe @clausnagel @Son-HNguyen

This PR migrates the Docker image for the Webclient from tum-gis/3dcitydb-web-map-docker to this repo.
Moreover, it add a build workflow for building edge and release version images and deploying them to ghcr.io and DockerHub. All image are built for amd64 and arm64 arch.

A test image is available here:
https://github.com/3dcitydb/3dcitydb-web-map/pkgs/container/3dcitydb-web-map-client

Please try out the new image and let me know if you come accross any issues.
@benediktschwab Thx for testing the arm64 build.

ToDos

  • Migrate Docker image form tum-gis/3dcitydb-web-map-docker, see Migrate to official web map client repo tum-gis/3dcitydb-web-map-docker#7
  • Add build workflows
    • Multi arch support (amd64, arm64)
    • edge image workflow
    • release image workflow
  • Reduce image size
    • Drop examples (link to examples?)
    • Offer alpine and debian based versions, or is only alpine fine? --> debian-slim base image size is fine.
  • Update server.js to use got instead of deprecated request library
  • Update html Docker image landing page
  • Archive tum-gis/3dcitydb-web-map-docker repo
  • After merging this to master, we need to create a release (v2.0.1) to trigger the build workflows and have a first release version published
  • Update documentation on ReadTheDocs, if necessary
  • Update CHANGES.md

@BWibo BWibo self-assigned this Nov 13, 2024
@BWibo
Copy link
Member Author

BWibo commented Nov 25, 2024

Hey @Son-HNguyen,

some questions came up:

  • There is the folder ts and tsconfig.json in the repo. Do I need to run a ts build before I put together the data in the image for the express server?
  • What about build.xml is that file still up-to-date and being used?

@Son-HNguyen
Copy link
Member

@BWibo The TypeScript files should only be built if they have been changed. Otherwise, the built JavaScript files are already stored.

The build.xml is not being used.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants