Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: update dependencies #6

Merged
merged 1 commit into from
Jan 27, 2020
Merged

chore: update dependencies #6

merged 1 commit into from
Jan 27, 2020

Conversation

jvhoven
Copy link
Contributor

@jvhoven jvhoven commented Jan 25, 2020

  • Removed git add from Husky config as it now warns that it does this by default:

husky > pre-commit (node v12.11.0)
⚠ Some of your tasks use git add command. Please remove it from the config since all modifications made by tasks will be automatically added to the git commit index.

  • Modified JarbFieldProps to be in line with the FieldProps type definition from react-final-form.

For some reason, the tests fail on Node.js v10.16.3, but succeed on Node.js v12.x, I think it's fine to update to v12 since it is LTS as well. I've took the liberty to update the Travis config in this pull request. Let me know if this is alright.

@jvhoven jvhoven force-pushed the chore/upgrade-dependencies branch from 8f965ac to 66f5459 Compare January 25, 2020 17:04
@codecov
Copy link

codecov bot commented Jan 25, 2020

Codecov Report

Merging #6 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master     #6   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           6      6           
  Lines         197    197           
  Branches       41     41           
=====================================
  Hits          197    197
Impacted Files Coverage Δ
src/JarbField.tsx 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bcdd17...66f5459. Read the comment docs.

@jvhoven jvhoven mentioned this pull request Jan 25, 2020
1 task
@jvhoven jvhoven requested a review from MrHus January 25, 2020 18:18
@jvhoven
Copy link
Contributor Author

jvhoven commented Jan 26, 2020

image

You're not authorized to merge this pull request.

@MrHus MrHus merged commit e580263 into master Jan 27, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants