Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix empty messages on IRC #1897

Merged
merged 1 commit into from
Nov 26, 2022
Merged

Fix empty messages on IRC #1897

merged 1 commit into from
Nov 26, 2022

Conversation

jx11r
Copy link
Contributor

@jx11r jx11r commented Sep 24, 2022

image

instead of:

image

@codeclimate
Copy link

codeclimate bot commented Sep 24, 2022

Code Climate has analyzed commit b307375 and detected 0 issues on this pull request.

View more on Code Climate.

@jx11r
Copy link
Contributor Author

jx11r commented Oct 22, 2022 •
edited
Loading

Well, I just noticed this: https://github.com/42wim/matterbridge/wiki/Tengo
It should fix empty messages on IRC, but I wonder why this isn't the default behavior. I mean that users wouldn't want empty messages by default (especially on IRC, where they look bad).

I could also fix empty messages here: outmessage.tengo

@42wim
Copy link
Owner

42wim commented Nov 26, 2022

I think it's valid to remove empty lines on irc.

@42wim 42wim added this to the 1.26.0 milestone Nov 26, 2022
@42wim 42wim added the irc label Nov 26, 2022
@42wim 42wim merged commit 3ad5dea into 42wim:master Nov 26, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
irc
Projects
None yet
Milestone
1.26.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jx11r @42wim