Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add support for searching scrollback for specific posts/threads #533

Merged
merged 2 commits into from
Sep 13, 2023

Conversation

hloeung
Copy link
Collaborator

@hloeung hloeung commented Apr 22, 2023

This reduces the needs for searching through IRC client logs for specific post/threads by Mattermost IDs. Instead, we can use the scrollback feature, e.g.:

# Only show the first 5 posts in thread.
/msg mattermost scrollback 1n4gsc6g638q9y53drezgf44gy 5

# Show all posts within the returned thread.
/msg mattermost scrollback 1n4gsc6g638q9y53drezgf44gy 0

@hloeung
Copy link
Collaborator Author

hloeung commented Apr 22, 2023

Added workaround for mattermost/mattermost#23081

@hloeung hloeung force-pushed the scrollback-posts-threads branch 3 times, most recently from f52a956 to 7eb2917 Compare April 22, 2023 23:32
@hloeung hloeung marked this pull request as ready for review April 22, 2023 23:42
@hloeung hloeung requested a review from 42wim September 8, 2023 08:47
mm-go-irckit/service.go Outdated Show resolved Hide resolved
@42wim
Copy link
Owner

42wim commented Sep 9, 2023

matterclient PR has been merged

@hloeung hloeung requested a review from 42wim September 10, 2023 02:30
@42wim
Copy link
Owner

42wim commented Sep 10, 2023

vendored file needs to be removed also :)

@hloeung
Copy link
Collaborator Author

hloeung commented Sep 10, 2023

vendored file needs to be removed also :)

Oh ok, reverted the changes to the vendored file

@hloeung
Copy link
Collaborator Author

hloeung commented Sep 10, 2023

Cleaning it up cherry-picking the relevant commits into master

@hloeung
Copy link
Collaborator Author

hloeung commented Sep 10, 2023

Okay, now this is merge-able.

@42wim 42wim merged commit 38f89c4 into 42wim:master Sep 13, 2023
4 checks passed
@hloeung hloeung deleted the scrollback-posts-threads branch September 13, 2023 22:48
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants