Feature/better pagination handling: add: better pagination handling #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
johguentner
commented
Jul 10, 2022
johguentner
commented
- fix problem with next_cursor handling for database queries
- added raw extraction (->fillResult()) for 'has_more' and 'next_cursor' in EntityCollection (e.g. executed on querying databases)
- added ->offsetByResponse(...) for handling the offset based on the previous query result (query result = EntityCollection)
- added public functions for easy access to 'has_more' (->hasMoreEntries()) and 'next_cursor' (->nextCursor()) in EntityCollection
- fix problem with next_cursor handling for database queries - added raw extraction (->fillResult()) for 'has_more' and 'next_cursor' in EntityCollection (e.g. executed on querying databases) - added ->offsetByResponse(...) for handling the offset based on the previous query result (query result = EntityCollection) - added public functions for easy access to 'has_more' (->hasMoreEntries()) and 'next_cursor' (->nextCursor()) in EntityCollection
- and add return type to StartCursor '__toString'
- test without offset in query and with next_cursor in response - test with offset in query (from previous response) and without next_cursor in response
…om/5am-code/laravel-notion-api into feature/better-pagination-handling
mechelon
approved these changes
Jul 11, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.