Fix api base in url #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
64bit
approved these changes
Jul 25, 2023
There was a problem hiding this comment.
Hi @kirillkuzin
Always a pleasure to hear from library users :)
Good find and thank you for fixing the bug!
|
Even though it still is bug in library for correctness, I recalled why it was like that. I made an assumption that API endpoint for OpenAI will highly likely not change - is that still a good assumption? |
|
This is released in v0.12.2 |
|
Actually, I don't know the precise cases for this. I have received a message about that from one guy using my plugin. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! Thanks for this crate, which I'm using in my projects.
I found the bug: even if you specify api base in the config, the client will replace it when making a request (for openai config). So, this is the fix :)