Made ApiError r#type optional to support Azure Error responses
#95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @ChristopherJMiller for the PR. Based purely on spec it seems But if this works without making |
|
In local testing with my azure resource I'm now getting the full I'll keep an eye out if I encounter message also being not sent and report back |
|
This is released in v0.13.0 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made
ApiError::r#typean optional string to support the mismatch between Azure and OpenAI's specification. This will at least let Azure users view the actual error instead of receiving JSON Deserialization errors.Discussed in #94