Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

If the graphql.AddError err arg is nil, early return #3445

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

StevenACoffman
Copy link
Collaborator

@StevenACoffman StevenACoffman commented Dec 20, 2024

Fixes #3410 so that graphql.AddError is a no-op if the error is nil.

Signed-off-by: Steve Coffman steve@khanacademy.org

Signed-off-by: Steve Coffman <steve@khanacademy.org>
@coveralls
Copy link

Coverage Status

coverage: 73.887% (-0.02%) from 73.91%
when pulling 888df00 on add_error_nil_no_op
into b95ea13 on master.

@StevenACoffman StevenACoffman merged commit 3d0c92a into master Dec 20, 2024
18 checks passed
@StevenACoffman StevenACoffman deleted the add_error_nil_no_op branch December 20, 2024 19:43
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

graphql.AddError panics
2 participants