Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Prerelease Versioning Via Deployment Count #167

Merged
merged 3 commits into from
Nov 15, 2024
Merged

Conversation

CodeGat
Copy link
Member

@CodeGat CodeGat commented Nov 14, 2024

In this PR:

  • Update the logic for prerelease versions to use number of deployments + 1 instead of number of commits, which allows for rebases to model deployment repositories. This continues the convention of an ordinal number in the prerelease version, such as pr12-2 denoting the second deployment of the 12th PR.

NOTE: This means that failed deployments still take up a count. For example, if deployment 2 failed, but deployment 3 succeeded in the above example, only pr12-1 and pr12-3 would exist on the deployment target.

Important

Existing PRs that already have the existing environments counts used will not deploy successfully still

References #157
Closes #141

@CodeGat CodeGat self-assigned this Nov 14, 2024
@CodeGat CodeGat added type:enhancement Improvements to existing features priority:high labels Nov 14, 2024
@CodeGat CodeGat force-pushed the 157-spack-env-counter branch from b98e14e to 00fa254 Compare November 14, 2024 05:38
@harshula harshula self-requested a review November 15, 2024 00:20
Copy link
Contributor

@harshula harshula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
priority:high type:enhancement Improvements to existing features
Projects
Development

Successfully merging this pull request may close these issues.

Allow Rebases to Model Deployment PRs
2 participants