-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Attributable errors #2519
Draft
thomash-acinq
wants to merge
6
commits into
master
Choose a base branch
from
fat-errors
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Attributable errors #2519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you want to do interop testing, you can use lightningnetwork/lnd#7139. It supports fat errors as sender/intermediate/final node and populates the hold time field as well. |
1e54913
to
f370fa5
Compare
517301d
to
2f84f91
Compare
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2519 +/- ##
==========================================
+ Coverage 85.84% 85.86% +0.02%
==========================================
Files 216 217 +1
Lines 18158 18242 +84
Branches 760 798 +38
==========================================
+ Hits 15588 15664 +76
- Misses 2570 2578 +8
|
0a9290c
to
bd99f9a
Compare
912fda0
to
f31f81e
Compare
23ad6b0
to
5858fed
Compare
This commit adds support for creating and relaying attributable errors but does not ask for others to use them. Also doe snot advertize the feature.
5858fed
to
df0dab1
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an implementation of the fat error proposal lightning/bolts#1044